accel/habanalabs: don't wait for STS_OK after sending COMMS WFE

Sending COMMS_GOTO_WFE instructs the FW's CPU to halt (WFE state).
Once sent, FW's CPU isn't expected to continue communicating with LKD.
Therefore, the stage of waiting for COMMS_STS_OK should be skipped or
else waiting for COMMS_STS_OK will simply timeout, which will trigger
unexpected behavior.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/accel/habanalabs/common/firmware_if.c b/drivers/accel/habanalabs/common/firmware_if.c
index 781256d..59f61ec 100644 (file)
--- a/drivers/accel/habanalabs/common/firmware_if.c
+++ b/drivers/accel/habanalabs/common/firmware_if.c
@@ -1278,7 +1278,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev)
        /* Stop device CPU to make sure nothing bad happens */
        if (hdev->asic_prop.dynamic_fw_load) {
                rc = hl_fw_dynamic_send_protocol_cmd(hdev, &hdev->fw_loader,
-                               COMMS_GOTO_WFE, 0, true,
+                               COMMS_GOTO_WFE, 0, false,
                                hdev->fw_loader.cpu_timeout);
                if (rc)
                        dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");