anv: remove vk_sample_locations_state from emit_multisample
authorTapani Pälli <tapani.palli@intel.com>
Mon, 19 Sep 2022 12:52:38 +0000 (15:52 +0300)
committerMarge Bot <emma+marge@anholt.net>
Tue, 20 Sep 2022 03:59:04 +0000 (03:59 +0000)
State for sample locations is not used within this function.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18669>

src/intel/vulkan/anv_genX.h
src/intel/vulkan/genX_pipeline.c
src/intel/vulkan/genX_state.c

index 6c2a8cb..45ff550 100644 (file)
@@ -130,8 +130,7 @@ genX(emit_urb_setup)(struct anv_device *device, struct anv_batch *batch,
                      const unsigned entry_size[4],
                      enum intel_urb_deref_block_size *deref_block_size);
 
-void genX(emit_multisample)(struct anv_batch *batch, uint32_t samples,
-                            const struct vk_sample_locations_state *sl);
+void genX(emit_multisample)(struct anv_batch *batch, uint32_t samples);
 
 void genX(emit_sample_pattern)(struct anv_batch *batch,
                                const struct vk_sample_locations_state *sl);
index dd5b376..495b9cc 100644 (file)
@@ -756,8 +756,7 @@ emit_ms_state(struct anv_graphics_pipeline *pipeline,
 {
    /* On Gfx8+ 3DSTATE_MULTISAMPLE only holds the number of samples. */
    genX(emit_multisample)(&pipeline->base.batch,
-                          pipeline->rasterization_samples,
-                          NULL);
+                          pipeline->rasterization_samples);
 
    /* From the Vulkan 1.0 spec:
     *    If pSampleMask is NULL, it is treated as if the mask has all bits
index c813086..9d0b7c2 100644 (file)
@@ -622,17 +622,8 @@ genX(emit_l3_config)(struct anv_batch *batch,
 }
 
 void
-genX(emit_multisample)(struct anv_batch *batch, uint32_t samples,
-                       const struct vk_sample_locations_state *sl)
+genX(emit_multisample)(struct anv_batch *batch, uint32_t samples)
 {
-   if (sl != NULL) {
-      assert(sl->per_pixel == samples);
-      assert(sl->grid_size.width == 1);
-      assert(sl->grid_size.height == 1);
-   } else {
-      sl = vk_standard_sample_locations_state(samples);
-   }
-
    anv_batch_emit(batch, GENX(3DSTATE_MULTISAMPLE), ms) {
       ms.NumberofMultisamples       = __builtin_ffs(samples) - 1;