command, log: print with "log show" a full logbuffer
authorHeiko Schocher <hs@denx.de>
Thu, 16 Feb 2012 01:02:21 +0000 (01:02 +0000)
committerWolfgang Denk <wd@denx.de>
Fri, 30 Mar 2012 20:28:56 +0000 (22:28 +0200)
If the logbuffer contains LOGBUFF_LEN chars, they never got
printed with the "log show" command, because chars get
printed with the following for loop:

for (i = 0; i < (size & LOGBUFF_MASK); i++) {

with size = LOGBUFF_LEN and LOGBUFF_MASK = (LOGBUFF_LEN-1)
for loop never executed ...

Fix this.

Signed-off-by: Heiko Schocher <hs@denx.de>
Acked-by: Detlev Zundel <dzu@denx.de>
Fixed merge conflict.
Signed-off-by: Wolfgang Denk <wd@denx.de>
common/cmd_log.c

index f9fbe00..9a3fdc3 100644 (file)
@@ -219,7 +219,9 @@ int do_log (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                                start = log->v1.start;
                                size = log->v1.size;
                        }
-                       for (i=0; i < (size&LOGBUFF_MASK); i++) {
+                       if (size > LOGBUFF_LEN)
+                               size = LOGBUFF_LEN;
+                       for (i = 0; i < size; i++) {
                                s = lbuf+((start+i)&LOGBUFF_MASK);
                                putc (*s);
                        }