xfs: remove unnecessary xfs_qm_dqattach parameter
authorDarrick J. Wong <darrick.wong@oracle.com>
Fri, 4 May 2018 22:30:21 +0000 (15:30 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 10 May 2018 15:56:47 +0000 (08:56 -0700)
The flags argument is always zero, get rid of it.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/libxfs/xfs_attr.c
fs/xfs/xfs_bmap_util.c
fs/xfs/xfs_inode.c
fs/xfs/xfs_iomap.c
fs/xfs/xfs_iops.c
fs/xfs/xfs_qm.c
fs/xfs/xfs_quota.h
fs/xfs/xfs_reflink.c

index 35a1244..c3d02a6 100644 (file)
@@ -236,7 +236,7 @@ xfs_attr_set(
        args.op_flags = XFS_DA_OP_ADDNAME | XFS_DA_OP_OKNOENT;
        args.total = xfs_attr_calc_size(&args, &local);
 
-       error = xfs_qm_dqattach(dp, 0);
+       error = xfs_qm_dqattach(dp);
        if (error)
                return error;
 
@@ -427,7 +427,7 @@ xfs_attr_remove(
         */
        args.op_flags = XFS_DA_OP_OKNOENT;
 
-       error = xfs_qm_dqattach(dp, 0);
+       error = xfs_qm_dqattach(dp);
        if (error)
                return error;
 
index 696c3b6..518627c 100644 (file)
@@ -848,7 +848,7 @@ xfs_free_eofblocks(
                /*
                 * Attach the dquots to the inode up front.
                 */
-               error = xfs_qm_dqattach(ip, 0);
+               error = xfs_qm_dqattach(ip);
                if (error)
                        return error;
 
@@ -918,7 +918,7 @@ xfs_alloc_file_space(
        if (XFS_FORCED_SHUTDOWN(mp))
                return -EIO;
 
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                return error;
 
@@ -1169,7 +1169,7 @@ xfs_free_file_space(
 
        trace_xfs_free_file_space(ip);
 
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                return error;
 
index 5b2e084..74d5cbe 100644 (file)
@@ -1424,11 +1424,11 @@ xfs_link(
        if (XFS_FORCED_SHUTDOWN(mp))
                return -EIO;
 
-       error = xfs_qm_dqattach(sip, 0);
+       error = xfs_qm_dqattach(sip);
        if (error)
                goto std_return;
 
-       error = xfs_qm_dqattach(tdp, 0);
+       error = xfs_qm_dqattach(tdp);
        if (error)
                goto std_return;
 
@@ -1929,7 +1929,7 @@ xfs_inactive(
             ip->i_d.di_nextents > 0 || ip->i_delayed_blks > 0))
                truncate = 1;
 
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                return;
 
@@ -2592,11 +2592,11 @@ xfs_remove(
        if (XFS_FORCED_SHUTDOWN(mp))
                return -EIO;
 
-       error = xfs_qm_dqattach(dp, 0);
+       error = xfs_qm_dqattach(dp);
        if (error)
                goto std_return;
 
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                goto std_return;
 
index d03e65f..0880685 100644 (file)
@@ -224,7 +224,7 @@ xfs_iomap_write_direct(
         * necessary and move on to transaction setup.
         */
        xfs_iunlock(ip, lockmode);
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                return error;
 
@@ -692,7 +692,7 @@ xfs_iomap_write_allocate(
        /*
         * Make sure that the dquots are there.
         */
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                return error;
 
index a3ed3c8..5afe3c2 100644 (file)
@@ -855,7 +855,7 @@ xfs_setattr_size(
        /*
         * Make sure that the dquots are attached to the inode.
         */
-       error = xfs_qm_dqattach(ip, 0);
+       error = xfs_qm_dqattach(ip);
        if (error)
                return error;
 
index eb10636..3893f54 100644 (file)
@@ -378,8 +378,7 @@ done:
 
 int
 xfs_qm_dqattach(
-       struct xfs_inode        *ip,
-       uint                    flags)
+       struct xfs_inode        *ip)
 {
        int                     error;
 
@@ -387,7 +386,7 @@ xfs_qm_dqattach(
                return 0;
 
        xfs_ilock(ip, XFS_ILOCK_EXCL);
-       error = xfs_qm_dqattach_locked(ip, flags);
+       error = xfs_qm_dqattach_locked(ip, 0);
        xfs_iunlock(ip, XFS_ILOCK_EXCL);
 
        return error;
@@ -1926,7 +1925,7 @@ xfs_qm_vop_rename_dqattach(
                 */
                if (i == 0 || ip != i_tab[i-1]) {
                        if (XFS_NOT_DQATTACHED(mp, ip)) {
-                               error = xfs_qm_dqattach(ip, 0);
+                               error = xfs_qm_dqattach(ip);
                                if (error)
                                        return error;
                        }
index ce6506a..a4d3922 100644 (file)
@@ -90,7 +90,7 @@ extern struct xfs_dquot *xfs_qm_vop_chown(struct xfs_trans *,
 extern int xfs_qm_vop_chown_reserve(struct xfs_trans *, struct xfs_inode *,
                struct xfs_dquot *, struct xfs_dquot *,
                struct xfs_dquot *, uint);
-extern int xfs_qm_dqattach(struct xfs_inode *, uint);
+extern int xfs_qm_dqattach(struct xfs_inode *);
 extern int xfs_qm_dqattach_locked(struct xfs_inode *, uint);
 extern void xfs_qm_dqdetach(struct xfs_inode *);
 extern void xfs_qm_dqrele(struct xfs_dquot *);
@@ -132,7 +132,7 @@ static inline int xfs_trans_reserve_quota_bydquots(struct xfs_trans *tp,
 #define xfs_qm_vop_rename_dqattach(it)                                 (0)
 #define xfs_qm_vop_chown(tp, ip, old, new)                             (NULL)
 #define xfs_qm_vop_chown_reserve(tp, ip, u, g, p, fl)                  (0)
-#define xfs_qm_dqattach(ip, fl)                                                (0)
+#define xfs_qm_dqattach(ip)                                            (0)
 #define xfs_qm_dqattach_locked(ip, fl)                                 (0)
 #define xfs_qm_dqdetach(ip)
 #define xfs_qm_dqrele(d)
index 12d441a..7e2b807 100644 (file)
@@ -1361,7 +1361,7 @@ xfs_reflink_remap_range(
                goto out_unlock;
 
        /* Attach dquots to dest inode before changing block map */
-       ret = xfs_qm_dqattach(dest, 0);
+       ret = xfs_qm_dqattach(dest);
        if (ret)
                goto out_unlock;