powernv/pci: Allow any write trigger the diag dump
authorOliver O'Halloran <oohall@gmail.com>
Thu, 12 Sep 2019 05:29:44 +0000 (15:29 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 23 Jan 2020 10:31:20 +0000 (21:31 +1100)
Make the dump trigger off any input rather than just '1'. This allows you
to write "echo 1> dump_diag_data" and it'll do what you want rather than
erroring out pointlessly.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190912052945.12589-2-oohall@gmail.com
arch/powerpc/platforms/powernv/pci-ioda.c

index f2c7556..f0425bd 100644 (file)
@@ -3093,9 +3093,6 @@ static int pnv_pci_diag_data_set(void *data, u64 val)
        struct pnv_phb *phb = data;
        s64 ret;
 
-       if (val != 1ULL)
-               return -EINVAL;
-
        /* Retrieve the diag data from firmware */
        ret = opal_pci_get_phb_diag_data2(phb->opal_id, phb->diag_data,
                                          phb->diag_data_size);