ASoC: rsnd: indicate necessary error when clock start failed
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 1 Feb 2023 02:00:03 +0000 (02:00 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 1 Feb 2023 11:43:46 +0000 (11:43 +0000)
rsnd_ssi_master_clk_start() indicates error message if it couldn't
handle requested clock/rate, but it is not caring all cases.
This patch cares it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/874js66t7g.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/ssi.c

index 7ade6c5..8ddee5b 100644 (file)
@@ -303,15 +303,14 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
                return 0;
        }
 
+       ret = -EIO;
        main_rate = rsnd_ssi_clk_query(rdai, rate, chan, &idx);
-       if (!main_rate) {
-               dev_err(dev, "unsupported clock rate\n");
-               return -EIO;
-       }
+       if (!main_rate)
+               goto rate_err;
 
        ret = rsnd_adg_ssi_clk_try_start(mod, main_rate);
        if (ret < 0)
-               return ret;
+               goto rate_err;
 
        /*
         * SSI clock will be output contiguously
@@ -333,6 +332,10 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
                rsnd_mod_name(mod), chan, rate);
 
        return 0;
+
+rate_err:
+       dev_err(dev, "unsupported clock rate\n");
+       return ret;
 }
 
 static void rsnd_ssi_master_clk_stop(struct rsnd_mod *mod,