brcmfmac: make errors when setting roaming parameters non-fatal
authorSoeren Moch <smoch@web.de>
Wed, 11 Dec 2019 23:52:48 +0000 (00:52 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 18 Dec 2019 19:07:41 +0000 (21:07 +0200)
4359 dongles do not support setting roaming parameters (error -52).
Do not fail the 80211 configuration in this case.

Signed-off-by: Soeren Moch <smoch@web.de>
Acked-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

index 5598bbd..0cf13ce 100644 (file)
@@ -6012,19 +6012,17 @@ static s32 brcmf_dongle_roam(struct brcmf_if *ifp)
        roamtrigger[1] = cpu_to_le32(BRCM_BAND_ALL);
        err = brcmf_fil_cmd_data_set(ifp, BRCMF_C_SET_ROAM_TRIGGER,
                                     (void *)roamtrigger, sizeof(roamtrigger));
-       if (err) {
+       if (err)
                bphy_err(drvr, "WLC_SET_ROAM_TRIGGER error (%d)\n", err);
-               goto roam_setup_done;
-       }
 
        roam_delta[0] = cpu_to_le32(WL_ROAM_DELTA);
        roam_delta[1] = cpu_to_le32(BRCM_BAND_ALL);
        err = brcmf_fil_cmd_data_set(ifp, BRCMF_C_SET_ROAM_DELTA,
                                     (void *)roam_delta, sizeof(roam_delta));
-       if (err) {
+       if (err)
                bphy_err(drvr, "WLC_SET_ROAM_DELTA error (%d)\n", err);
-               goto roam_setup_done;
-       }
+
+       return 0;
 
 roam_setup_done:
        return err;