[sound] - Checking privileges moved to JS layer
authorAndrzej Popowski <a.popowski@samsung.com>
Thu, 30 Apr 2015 12:46:54 +0000 (14:46 +0200)
committerPawel Andruszkiewicz <p.andruszkie@samsung.com>
Mon, 4 May 2015 07:22:59 +0000 (16:22 +0900)
Change-Id: I34297aa480a1feb267efff17b9a9cde122c17f28
Signed-off-by: Andrzej Popowski <a.popowski@samsung.com>
src/sound/sound_api.js
src/sound/sound_instance.cc

index 3e2ebd93ab7fa400e83f2be8a7bb085d245f9705..2460657374576328cde3b937dd45a1e5c119394a 100644 (file)
@@ -7,6 +7,7 @@ var utils_ = xwalk.utils;
 var type_ = utils_.type;
 var converter_ = utils_.converter;
 var validator_ = utils_.validator;
+var privilege_ = utils_.privilege;
 var types_ = validator_.Types;
 var native_ = new xwalk.utils.NativeManager(extension);
 
@@ -94,6 +95,8 @@ SoundManager.prototype.getSoundMode = function() {
 };
 
 SoundManager.prototype.setVolume = function(type, volume) {
+  utils_.checkPrivilegeAccess(privilege_.VOLUME_SET);
+
   var args = validator_.validateArgs(arguments, [
     {name: 'type', type: types_.ENUM, values: Object.keys(SoundType)},
     {name: 'volume', type: types_.DOUBLE}
index c364255c7a11c7bb9a740eece7e87b2b74d8244b..0c7c8bf35bc430cf0be508704db601ceed38e1ae 100644 (file)
 namespace extension {
 namespace sound {
 
-namespace {
-// The privileges that required in Sound API
-const std::string kPrivilegeSound = "http://tizen.org/privilege/volume.set";
-
-} // namespace
-
 using namespace common;
 using namespace extension::sound;
 
@@ -67,7 +61,6 @@ void SoundInstance::SoundManagerGetSoundMode(const picojson::value& args,
 
 void SoundInstance::SoundManagerSetVolume(const picojson::value& args,
                                           picojson::object& out) {
-  CHECK_PRIVILEGE_ACCESS(kPrivilegeSound, &out);
   PlatformResult status = manager_.SetVolume(args.get<picojson::object>());
 
   if (status.IsSuccess())