staging/wlan-ng: Remove all strcpy() uses in favor of strscpy()

strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors. The safe replacement is strscpy().

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210717152032.10164-1-len.baker@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 94800c0..02a2191 100644 (file)
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -296,7 +296,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
        memset(&getmsg, 0, sizeof(getmsg));
        getmsg.msgcode = DIDMSG_DOT11REQ_MIBGET;
        getmsg.msglen = sizeof(getmsg);
-       strcpy(getmsg.devname, wlandev->name);
+       strscpy(getmsg.devname, wlandev->name, sizeof(getmsg.devname));
 
        getmsg.mibattribute.did = DIDMSG_DOT11REQ_MIBGET_MIBATTRIBUTE;
        getmsg.mibattribute.status = P80211ENUM_msgitem_status_data_ok;
@@ -786,7 +786,7 @@ static int read_cardpda(struct pda *pda, struct wlandevice *wlandev)
        /* set up the msg */
        msg->msgcode = DIDMSG_P2REQ_READPDA;
        msg->msglen = sizeof(msg);
-       strcpy(msg->devname, wlandev->name);
+       strscpy(msg->devname, wlandev->name, sizeof(msg->devname));
        msg->pda.did = DIDMSG_P2REQ_READPDA_PDA;
        msg->pda.len = HFA384x_PDA_LEN_MAX;
        msg->pda.status = P80211ENUM_msgitem_status_no_value;
@@ -1017,7 +1017,7 @@ static int writeimage(struct wlandevice *wlandev, struct imgchunk *fchunk,
        }
 
        /* Initialize the messages */
-       strcpy(rstmsg->devname, wlandev->name);
+       strscpy(rstmsg->devname, wlandev->name, sizeof(rstmsg->devname));
        rstmsg->msgcode = DIDMSG_P2REQ_RAMDL_STATE;
        rstmsg->msglen = sizeof(*rstmsg);
        rstmsg->enable.did = DIDMSG_P2REQ_RAMDL_STATE_ENABLE;
@@ -1030,7 +1030,7 @@ static int writeimage(struct wlandevice *wlandev, struct imgchunk *fchunk,
        rstmsg->exeaddr.len = sizeof(u32);
        rstmsg->resultcode.len = sizeof(u32);
 
-       strcpy(rwrmsg->devname, wlandev->name);
+       strscpy(rwrmsg->devname, wlandev->name, sizeof(rwrmsg->devname));
        rwrmsg->msgcode = DIDMSG_P2REQ_RAMDL_WRITE;
        rwrmsg->msglen = sizeof(*rwrmsg);
        rwrmsg->addr.did = DIDMSG_P2REQ_RAMDL_WRITE_ADDR;