Fix double-free in unit test on Windows.
authorRobert Hencke <robert.hencke@gmail.com>
Sun, 6 Sep 2015 13:53:22 +0000 (09:53 -0400)
committerRobert Hencke <robert.hencke@gmail.com>
Sun, 6 Sep 2015 13:53:22 +0000 (09:53 -0400)
The LOG_SYSRESULT refers to result twice.  Since, in this test,
result expands to FindClose(handle), the handle was being freed twice.

src/logging_unittest.cc

index e180567..e0e3676 100644 (file)
@@ -635,7 +635,8 @@ static void GetFiles(const string& pattern, vector<string>* files) {
   do {
     files->push_back(dirname + data.cFileName);
   } while (FindNextFileA(handle, &data));
-  LOG_SYSRESULT(FindClose(handle));
+  BOOL result = FindClose(handle);
+  LOG_SYSRESULT(result);
 #else
 # error There is no way to do glob.
 #endif