dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet
authorTuo Cao <91tuocao@gmail.com>
Sun, 14 Aug 2022 13:13:23 +0000 (21:13 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 29 Sep 2022 06:51:33 +0000 (12:21 +0530)
it is unnecessary to call read_lock_bh in a tasklet.

Signed-off-by: Tuo Cao <91tuocao@gmail.com>
Link: https://lore.kernel.org/r/20220814131323.7029-1-91tuocao@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/gpi.c

index 8983986..3f56514 100644 (file)
@@ -1150,9 +1150,9 @@ static void gpi_ev_tasklet(unsigned long data)
 {
        struct gpii *gpii = (struct gpii *)data;
 
-       read_lock_bh(&gpii->pm_lock);
+       read_lock(&gpii->pm_lock);
        if (!REG_ACCESS_VALID(gpii->pm_state)) {
-               read_unlock_bh(&gpii->pm_lock);
+               read_unlock(&gpii->pm_lock);
                dev_err(gpii->gpi_dev->dev, "not processing any events, pm_state:%s\n",
                        TO_GPI_PM_STR(gpii->pm_state));
                return;
@@ -1163,7 +1163,7 @@ static void gpi_ev_tasklet(unsigned long data)
 
        /* enable IEOB, switching back to interrupts */
        gpi_config_interrupts(gpii, MASK_IEOB_SETTINGS, 1);
-       read_unlock_bh(&gpii->pm_lock);
+       read_unlock(&gpii->pm_lock);
 }
 
 /* marks all pending events for the channel as stale */