elm_box: Fix miscalculated items' size issue in homogeneous box

Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.

T2033

Reviewers: Hermet, seoz

Subscribers: seoz, Hermet

Maniphest Tasks: T2033

Differential Revision: https://phab.enlightenment.org/D2016

diff --git a/legacy/elementary/src/lib/els_box.c b/legacy/elementary/src/lib/els_box.c
index 7a8d386..fdcd3bf 100644 (file)
--- a/legacy/elementary/src/lib/els_box.c
+++ b/legacy/elementary/src/lib/els_box.c
@@ -199,7 +199,7 @@ _els_box_layout(Evas_Object *o, Evas_Object_Box_Data *priv, Eina_Bool horizontal
 
              if (homogeneous)
                {
-                  ww = (w / (Evas_Coord)count);
+                  ww = ((w - (count - 1) * priv->pad.h) / (Evas_Coord)count);
                }
              else
                {
@@ -231,7 +231,7 @@ _els_box_layout(Evas_Object *o, Evas_Object_Box_Data *priv, Eina_Bool horizontal
 
              if (homogeneous)
                {
-                  hh = (h / (Evas_Coord)count);
+                  hh = ((h - (count - 1) * priv->pad.v) / (Evas_Coord)count);
                }
              else
                {