projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4b963ae
)
ALSA: firewire-digi00x: prevent potential use after free
author
Dan Carpenter
<dan.carpenter@linaro.org>
Tue, 9 May 2023 09:07:11 +0000
(12:07 +0300)
committer
Takashi Iwai
<tiwai@suse.de>
Fri, 12 May 2023 08:18:05 +0000
(10:18 +0200)
This code was supposed to return an error code if init_stream()
failed, but it instead freed dg00x->rx_stream and returned success.
This potentially leads to a use after free.
Fixes:
9a08067ec318
("ALSA: firewire-digi00x: support AMDTP domain")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link:
https://lore.kernel.org/r/c224cbd5-d9e2-4cd4-9bcf-2138eb1d35c6@kili.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/digi00x/digi00x-stream.c
patch
|
blob
|
history
diff --git
a/sound/firewire/digi00x/digi00x-stream.c
b/sound/firewire/digi00x/digi00x-stream.c
index
a15f55b
..
295163b
100644
(file)
--- a/
sound/firewire/digi00x/digi00x-stream.c
+++ b/
sound/firewire/digi00x/digi00x-stream.c
@@
-259,8
+259,10
@@
int snd_dg00x_stream_init_duplex(struct snd_dg00x *dg00x)
return err;
err = init_stream(dg00x, &dg00x->tx_stream);
- if (err < 0)
+ if (err < 0)
{
destroy_stream(dg00x, &dg00x->rx_stream);
+ return err;
+ }
err = amdtp_domain_init(&dg00x->domain);
if (err < 0) {