scsi: mac53c94: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:42 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:48 +0000 (21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-48-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mac53c94.c

index ec9840d..9731855 100644 (file)
@@ -83,7 +83,6 @@ static int mac53c94_queue_lck(struct scsi_cmnd *cmd, void (*done)(struct scsi_cm
        }
 #endif
 
-       cmd->scsi_done = done;
        cmd->host_scribble = NULL;
 
        state = (struct fsc_state *) cmd->device->host->hostdata;
@@ -348,7 +347,7 @@ static void cmd_done(struct fsc_state *state, int result)
        cmd = state->current_req;
        if (cmd) {
                cmd->result = result;
-               (*cmd->scsi_done)(cmd);
+               scsi_done(cmd);
                state->current_req = NULL;
        }
        state->phase = idle;