usb: host: xhci: convert several if() to a single switch statement
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 23 Jan 2017 12:20:21 +0000 (14:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Jan 2017 10:00:01 +0000 (11:00 +0100)
when getting endpoint type, a switch statement looks
better than a series of if () branches. There are no
functional changes with this patch, cleanup only.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-mem.c

index 0640e76..0019094 100644 (file)
@@ -1414,14 +1414,16 @@ static u32 xhci_get_endpoint_type(struct usb_host_endpoint *ep)
 
        in = usb_endpoint_dir_in(&ep->desc);
 
-       if (usb_endpoint_xfer_control(&ep->desc))
+       switch (usb_endpoint_type(&ep->desc)) {
+       case USB_ENDPOINT_XFER_CONTROL:
                return CTRL_EP;
-       if (usb_endpoint_xfer_bulk(&ep->desc))
+       case USB_ENDPOINT_XFER_BULK:
                return in ? BULK_IN_EP : BULK_OUT_EP;
-       if (usb_endpoint_xfer_isoc(&ep->desc))
+       case USB_ENDPOINT_XFER_ISOC:
                return in ? ISOC_IN_EP : ISOC_OUT_EP;
-       if (usb_endpoint_xfer_int(&ep->desc))
+       case USB_ENDPOINT_XFER_INT:
                return in ? INT_IN_EP : INT_OUT_EP;
+       }
        return 0;
 }