Fix DefineOwnProperty for data properties wrt failed access checks
authorverwaest <verwaest@chromium.org>
Fri, 17 Jul 2015 12:55:16 +0000 (05:55 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 17 Jul 2015 12:55:33 +0000 (12:55 +0000)
BUG=chromium:509936
LOG=y

Review URL: https://codereview.chromium.org/1241973003

Cr-Commit-Position: refs/heads/master@{#29727}

src/objects.cc

index bb3bb5f..c7b37e5 100644 (file)
@@ -4191,7 +4191,9 @@ MaybeHandle<Object> JSObject::DefineOwnPropertyIgnoreAttributes(
 
       case LookupIterator::ACCESS_CHECK:
         if (!it->HasAccess()) {
-          return SetPropertyWithFailedAccessCheck(it, value);
+          it->isolate()->ReportFailedAccessCheck(it->GetHolder<JSObject>());
+          RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(it->isolate(), Object);
+          return value;
         }
         break;