gst/gstpad.c: Can't access event structure after giving away ownership of the event.

Original commit message from CVS:
* gst/gstpad.c: (gst_pad_push_event):
Can't access event structure after giving away ownership of
the event.

diff --git a/ChangeLog b/ChangeLog
index 62d890b..98c4683 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-11-15  Tim-Philipp Müller  <tim at centricular dot net>
+
+       * gst/gstpad.c: (gst_pad_push_event):
+         Can't access event structure after giving away ownership of
+         the event.
+
 2006-11-15  Stefan Kost  <ensonic@users.sf.net>
 
        * docs/random/ensonic/embedded.txt:
@@ -22,7 +28,7 @@
 
 2006-11-10  Tim-Philipp Müller  <tim at centricular dot net>
 
-       Patch by: Sergey Scobich  <sergery.scobich at gmail com>
+       Patch by: Sergey Scobich  <sergey.scobich at gmail com>
 
        * win32/common/libgstreamer.def:
          Add two missing symbols (#366492).

diff --git a/gst/gstpad.c b/gst/gstpad.c
index 49708e8..7031b3d 100644 (file)
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -3878,7 +3878,7 @@ gst_pad_push_event (GstPad * pad, GstEvent * event)
   g_return_val_if_fail (event != NULL, FALSE);
   g_return_val_if_fail (GST_IS_EVENT (event), FALSE);
 
-  GST_LOG_OBJECT (pad, "event:%s", GST_EVENT_TYPE_NAME (event));
+  GST_LOG_OBJECT (pad, "event: %s", GST_EVENT_TYPE_NAME (event));
 
   GST_OBJECT_LOCK (pad);
 
@@ -3936,8 +3936,8 @@ gst_pad_push_event (GstPad * pad, GstEvent * event)
 
   result = gst_pad_send_event (peerpad, event);
 
-  GST_LOG_OBJECT (pad, "sent event %s to peerpad %" GST_PTR_FORMAT,
-      GST_EVENT_TYPE_NAME (event), peerpad);
+  /* Note: we gave away ownership of the event at this point */
+  GST_LOG_OBJECT (pad, "sent event to peerpad %" GST_PTR_FORMAT, peerpad);
   gst_object_unref (peerpad);
 
   return result;