drm/i915/guc: Correctly free guc capture struct on error
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Thu, 24 Mar 2022 00:04:39 +0000 (17:04 -0700)
committerDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Fri, 25 Mar 2022 17:07:24 +0000 (10:07 -0700)
On error the "new" allocation is not freed, so add the required kfree.

Fixes: 247f8071d5893 ("drm/i915/guc: Pre-allocate output nodes for extraction")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: John Harrison <john.c.harrison@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220324000439.2370440-1-daniele.ceraolospurio@intel.com
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c

index afdcbe6..c4e2596 100644 (file)
@@ -1040,6 +1040,7 @@ guc_capture_alloc_one_node(struct intel_guc *guc)
                if (!new->reginfo[i].regs) {
                        while (i)
                                kfree(new->reginfo[--i].regs);
+                       kfree(new);
                        return NULL;
                }
        }