wifi: iwlwifi: mvm: send LARI configuration earlier
authorBenjamin Berg <benjamin.berg@intel.com>
Tue, 20 Jun 2023 10:03:58 +0000 (13:03 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 21 Jun 2023 12:02:15 +0000 (14:02 +0200)
Sending the LARI configuration may trigger calibration, which can have
undesired side effects. Move the command to be send earlier (before the
phy contexts are registered) to avoid unintended side effects.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230620125813.80742497eb3f.I3e599a796290082e6d331ea495a5591d55de4726@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/fw.c

index 77cdfb4..1f5db65 100644 (file)
@@ -1566,6 +1566,8 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
                        goto error;
        }
 
+       iwl_mvm_lari_cfg(mvm);
+
        /* Init RSS configuration */
        ret = iwl_configure_rxq(&mvm->fwrt);
        if (ret)
@@ -1676,7 +1678,6 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
        if (ret)
                goto error;
 
-       iwl_mvm_lari_cfg(mvm);
        /*
         * RTNL is not taken during Ct-kill, but we don't need to scan/Tx
         * anyway, so don't init MCC.