Env.pm: Fix splice in list context

It was passing an extra argument to splice, causing splice @PATH, 0, 0
to append ":0" to the environment variable.

diff --git a/dist/Env/lib/Env.pm b/dist/Env/lib/Env.pm
index 1f3713a..6e6cd8b 100644 (file)
--- a/dist/Env/lib/Env.pm
+++ b/dist/Env/lib/Env.pm
@@ -211,7 +211,7 @@ sub SPLICE {
     my $length = shift;
     my @temp = split($sep, $ENV{$$self});
     if (wantarray) {
-       my @result = splice @temp, $self, $offset, $length, @_;
+       my @result = splice @temp, $offset, $length, @_;
        $ENV{$$self} = join($sep, @temp);
        return @result;
     } else {

diff --git a/dist/Env/t/array.t b/dist/Env/t/array.t
index 9e87f4a..d029174 100644 (file)
--- a/dist/Env/t/array.t
+++ b/dist/Env/t/array.t
@@ -6,7 +6,7 @@ use strict;
 use Test::More;
 
 plan(skip_all => "skipped for VMS") if $^O eq 'VMS';
-plan(tests => 11);
+plan(tests => 12);
 
 use Env  qw(@FOO);
 use vars qw(@BAR);
@@ -64,3 +64,7 @@ is_deeply(\@FOO, \@BAR, "Sort");
 splice @FOO, 1, 1, 'B';
 splice @BAR, 1, 1, 'B';
 is_deeply(\@FOO, \@BAR, "Splice");
+
+my $foo = $ENV{FOO};
+() = splice @FOO, 0, 0;
+is $ENV{FOO}, $foo, 'Splice in list context';