dmaengine: idxd: set DMA channel to be private
authorDave Jiang <dave.jiang@intel.com>
Fri, 15 Jan 2021 21:53:07 +0000 (14:53 -0700)
committerVinod Koul <vkoul@kernel.org>
Sun, 17 Jan 2021 06:50:12 +0000 (12:20 +0530)
Add DMA_PRIVATE attribute flag to idxd DMA channels. The dedicated WQs are
expected to be used by a single client and not shared. While doing NTB
testing this mistake was discovered, which prevented ntb_transport from
requesting DSA wqs as DMA channels via dma_request_channel().

Reported-by: Srinijia Kambham <srinija.kambham@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Tested-by: Srinijia Kambham <srinija.kambham@intel.com>
Fixes: 8f47d1a5e545 ("dmaengine: idxd: connect idxd to dmaengine subsystem")
Link: https://lore.kernel.org/r/161074758743.2184057.3388557138816350980.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/dma.c

index 8ed2773..90d19d0 100644 (file)
@@ -165,6 +165,7 @@ int idxd_register_dma_device(struct idxd_device *idxd)
        INIT_LIST_HEAD(&dma->channels);
        dma->dev = &idxd->pdev->dev;
 
+       dma_cap_set(DMA_PRIVATE, dma->cap_mask);
        dma_cap_set(DMA_COMPLETION_NO_ORDER, dma->cap_mask);
        dma->device_release = idxd_dma_release;