xfs: shorten the shutdown messages to a single line
authorDarrick J. Wong <djwong@kernel.org>
Mon, 21 Jun 2021 17:01:14 +0000 (10:01 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Mon, 21 Jun 2021 17:14:13 +0000 (10:14 -0700)
Consolidate the shutdown messages to a single line containing the
reason, the passed-in flags, the source of the shutdown, and the end
result.  This means we now only have one line to look for when
debugging, which is useful when the fs goes down while something else is
flooding dmesg.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
fs/xfs/xfs_fsops.c

index b7f979e..6ed29b1 100644 (file)
@@ -538,25 +538,25 @@ xfs_do_force_shutdown(
 
        if (flags & SHUTDOWN_FORCE_UMOUNT) {
                xfs_alert(mp,
-"User initiated shutdown received. Shutting down filesystem");
+"User initiated shutdown (0x%x) received. Shutting down filesystem",
+                               flags);
                return;
        }
 
-       xfs_notice(mp,
-"%s(0x%x) called from line %d of file %s. Return address = %pS",
-               __func__, flags, lnnum, fname, __return_address);
-
        if (flags & SHUTDOWN_CORRUPT_INCORE) {
                xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT,
-"Corruption of in-memory data detected.  Shutting down filesystem");
+"Corruption of in-memory data (0x%x) detected at %pS (%s:%d).  Shutting down filesystem",
+                               flags, __return_address, fname, lnnum);
                if (XFS_ERRLEVEL_HIGH <= xfs_error_level)
                        xfs_stack_trace();
        } else if (logerror) {
                xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_LOGERROR,
-                       "Log I/O Error Detected. Shutting down filesystem");
+"Log I/O error (0x%x) detected at %pS (%s:%d). Shutting down filesystem",
+                               flags, __return_address, fname, lnnum);
        } else {
                xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_IOERROR,
-                       "I/O Error Detected. Shutting down filesystem");
+"I/O error (0x%x) detected at %pS (%s:%d). Shutting down filesystem",
+                               flags, __return_address, fname, lnnum);
        }
 
        xfs_alert(mp,