Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of https://codereview.chromi...
authormtklein <mtklein@google.com>
Fri, 21 Nov 2014 22:42:35 +0000 (14:42 -0800)
committerCommit bot <commit-bot@chromium.org>
Fri, 21 Nov 2014 22:42:35 +0000 (14:42 -0800)
Reason for revert:
Not clean yet.

Original issue's description:
> Add -ftrapv to debug builds.
>
> This adds instrumentation to check that signed integers never under- or
> overflow, which is undefined behavior.
>
> BUG=skia:3096
>
> Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c

TBR=bungeman@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3096

Review URL: https://codereview.chromium.org/751713002

gyp/common_conditions.gypi

index 1684151..059806f 100644 (file)
             'ldflags': ['--coverage'],
           },
           'Debug': {
-            'cflags': ['-ftrapv'],  # Crash on signed integer over/underflow.
           },
           'Release': {
             'cflags': [
         ],
         'configurations': {
           'Debug': {
-            'cflags': ['-g', '-ftrapv']
+            'cflags': ['-g']
           },
           'Release': {
             'cflags': ['-O2'],