Add more role defaults

diff --git a/default_app/main.js b/default_app/main.js
index 45ff78e..a484c03 100644 (file)
--- a/default_app/main.js
+++ b/default_app/main.js
@@ -151,14 +151,12 @@ app.once('ready', () => {
       label: 'Electron',
       submenu: [
         {
-          label: 'About Electron',
           role: 'about'
         },
         {
           type: 'separator'
         },
         {
-          label: 'Services',
           role: 'services',
           submenu: []
         },
@@ -166,49 +164,36 @@ app.once('ready', () => {
           type: 'separator'
         },
         {
-          label: 'Hide Electron',
-          accelerator: 'Command+H',
           role: 'hide'
         },
         {
-          label: 'Hide Others',
-          accelerator: 'Command+Alt+H',
           role: 'hideothers'
         },
         {
-          label: 'Show All',
           role: 'unhide'
         },
         {
           type: 'separator'
         },
         {
-          label: 'Quit ' + app.getName(),
-          accelerator: 'Command+Q',
           role: 'quit'
         }
       ]
     })
     template[3].submenu = [
       {
-        label: 'Close',
-        accelerator: 'CmdOrCtrl+W',
         role: 'close'
       },
       {
-        label: 'Minimize',
-        accelerator: 'CmdOrCtrl+M',
         role: 'minimize'
       },
       {
-        label: 'Zoom',
         role: 'zoom'
       },
       {
         type: 'separator'
       },
       {
-        label: 'Bring All to Front',
         role: 'front'
       }
     ]
@@ -219,7 +204,6 @@ app.once('ready', () => {
       label: 'File',
       submenu: [
         {
-          label: 'Exit',
           role: 'quit'
         }
       ]

diff --git a/lib/browser/api/menu-item-roles.js b/lib/browser/api/menu-item-roles.js
index c78ff8a..a5373c6 100644 (file)
--- a/lib/browser/api/menu-item-roles.js
+++ b/lib/browser/api/menu-item-roles.js
@@ -67,6 +67,35 @@ const roles = {
   },
   window: {
     label: 'Window'
+  },
+  services: {
+    label: 'Services'
+  },
+  zoom: {
+    label: 'Zoom'
+  },
+  front: {
+    label: 'Bring All to Front'
+  },
+  about: {
+    get label () {
+      const {app} = require('electron')
+      return `About ${app.getName()}`
+    }
+  },
+  hide: {
+    get label () {
+      const {app} = require('electron')
+      return return `Hide ${app.getName()}`
+    },
+    accelerator: 'Command+H'
+  },
+  hideothers: {
+    label: 'Hide Others',
+    accelerator: 'Command+Alt+H'
+  },
+  unhide: {
+    label: 'Show All'
   }
 }