iwlwifi: dbg: don't stop dbg recording before entering D3 from 9000 devices
authorShahar S Matityahu <shahar.s.matityahu@intel.com>
Sun, 19 May 2019 07:16:13 +0000 (10:16 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Sat, 29 Jun 2019 07:09:43 +0000 (10:09 +0300)
From 9000 device family the FW automatically stops the debug
recording and the driver should not stop it as well.

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/d3.c

index 749912b..0e3db81 100644 (file)
@@ -1078,11 +1078,12 @@ static int __iwl_mvm_suspend(struct ieee80211_hw *hw,
 #endif
 
        /*
-        * TODO: this is needed because the firmware is not stopping
-        * the recording automatically before entering D3.  This can
-        * be removed once the FW starts doing that.
+        * Prior to 9000 device family the driver needs to stop the dbg
+        * recording before entering D3. In later devices the FW stops the
+        * recording automatically.
         */
-       _iwl_fw_dbg_stop_recording(mvm->fwrt.trans, NULL);
+       if (mvm->trans->cfg->device_family < IWL_DEVICE_FAMILY_9000)
+               _iwl_fw_dbg_stop_recording(mvm->trans, NULL);
 
        /* must be last -- this switches firmware state */
        ret = iwl_mvm_send_cmd(mvm, &d3_cfg_cmd);