staging: r8188eu: drop redundant if check
authorVihas Makwana <makvihas@gmail.com>
Sun, 8 May 2022 18:24:01 +0000 (23:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 May 2022 15:41:06 +0000 (17:41 +0200)
The check for ETH_P_IP is already performed in the outer if block
and inner if check is redundant. So drop the check.

Signed-off-by: Vihas Makwana <makvihas@gmail.com>
Link: https://lore.kernel.org/r/20220508182400.22433-1-makvihas@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_xmit.c

index d086812..9a99aa5 100644 (file)
@@ -448,14 +448,12 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
                _rtw_pktfile_read(&pktfile, &tmp[0], 24);
                pattrib->dhcp_pkt = 0;
                if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */
-                       if (ETH_P_IP == pattrib->ether_type) {/*  IP header */
-                               if (((tmp[21] == 68) && (tmp[23] == 67)) ||
-                                   ((tmp[21] == 67) && (tmp[23] == 68))) {
-                                       /*  68 : UDP BOOTP client */
-                                       /*  67 : UDP BOOTP server */
-                                       /*  Use low rate to send DHCP packet. */
-                                       pattrib->dhcp_pkt = 1;
-                               }
+                       if (((tmp[21] == 68) && (tmp[23] == 67)) ||
+                           ((tmp[21] == 67) && (tmp[23] == 68))) {
+                               /*  68 : UDP BOOTP client */
+                               /*  67 : UDP BOOTP server */
+                               /*  Use low rate to send DHCP packet. */
+                               pattrib->dhcp_pkt = 1;
                        }
                }
        }