eeprom: idt_89hpesx: clean up an error pointer vs NULL inconsistency
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 2 Aug 2018 08:27:21 +0000 (11:27 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Aug 2018 08:42:25 +0000 (10:42 +0200)
We check for IS_ERR_OR_NULL() here, but later we check the same thing
for NULL only.  It turns out that it can only be NULL so we can make the
checking consistent by removing the ERR_PTR stuff.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/idt_89hpesx.c

index 119eb05..8a46595 100644 (file)
@@ -1128,7 +1128,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev)
 
        device_for_each_child_node(dev, fwnode) {
                ee_id = idt_ee_match_id(fwnode);
-               if (IS_ERR_OR_NULL(ee_id)) {
+               if (!ee_id) {
                        dev_warn(dev, "Skip unsupported EEPROM device");
                        continue;
                } else