Fix has_pending_exception logic in API's Array::CloneElementAt
authorjkummerow <jkummerow@chromium.org>
Tue, 19 May 2015 11:35:02 +0000 (04:35 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 19 May 2015 11:34:45 +0000 (11:34 +0000)
BUG=v8:4103
LOG=y
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/1138723003

Cr-Commit-Position: refs/heads/master@{#28477}

src/api.cc

index bd915ef..a688238 100644 (file)
@@ -6078,8 +6078,9 @@ MaybeLocal<Object> Array::CloneElementAt(Local<Context> context,
   if (!paragon->IsJSObject()) return Local<Object>();
   i::Handle<i::JSObject> paragon_handle(i::JSObject::cast(paragon));
   Local<Object> result;
-  has_pending_exception = ToLocal<Object>(
-      isolate->factory()->CopyJSObject(paragon_handle), &result);
+  has_pending_exception =
+      !ToLocal<Object>(isolate->factory()->CopyJSObject(paragon_handle),
+                       &result);
   RETURN_ON_FAILED_EXECUTION(Object);
   RETURN_ESCAPED(result);
 }