mfd: at91-usart: No need to copy mfd_cell in probe
authorAxel Lin <axel.lin@ingics.com>
Thu, 31 Jan 2019 04:32:13 +0000 (12:32 +0800)
committerLee Jones <lee.jones@linaro.org>
Thu, 7 Feb 2019 10:44:09 +0000 (10:44 +0000)
Use pointer instead.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/at91-usart.c

index 684d3a8..6a8351a 100644 (file)
@@ -27,17 +27,17 @@ static const struct mfd_cell at91_usart_serial_subdev = {
 
 static int at91_usart_mode_probe(struct platform_device *pdev)
 {
-       struct mfd_cell cell;
+       const struct mfd_cell *cell;
        u32 opmode = AT91_USART_MODE_SERIAL;
 
        device_property_read_u32(&pdev->dev, "atmel,usart-mode", &opmode);
 
        switch (opmode) {
        case AT91_USART_MODE_SPI:
-               cell = at91_usart_spi_subdev;
+               cell = &at91_usart_spi_subdev;
                break;
        case AT91_USART_MODE_SERIAL:
-               cell = at91_usart_serial_subdev;
+               cell = &at91_usart_serial_subdev;
                break;
        default:
                dev_err(&pdev->dev, "atmel,usart-mode has an invalid value %u\n",
@@ -45,7 +45,7 @@ static int at91_usart_mode_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, &cell, 1,
+       return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, cell, 1,
                              NULL, 0, NULL);
 }