projects
/
platform
/
kernel
/
linux-exynos.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f44f2a5
)
ALSA: sb16 - info leak in snd_sb_csp_ioctl()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 7 Nov 2013 08:09:54 +0000
(11:09 +0300)
committer
Takashi Iwai
<tiwai@suse.de>
Thu, 7 Nov 2013 09:17:18 +0000
(10:17 +0100)
There is a 2 byte hole after "info.func_nr" so we could leak unitialized
stack information to userspace.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/sb/sb16_csp.c
patch
|
blob
|
history
diff --git
a/sound/isa/sb/sb16_csp.c
b/sound/isa/sb/sb16_csp.c
index
c1aa21e
..
48da227
100644
(file)
--- a/
sound/isa/sb/sb16_csp.c
+++ b/
sound/isa/sb/sb16_csp.c
@@
-208,6
+208,7
@@
static int snd_sb_csp_ioctl(struct snd_hwdep * hw, struct file *file, unsigned i
switch (cmd) {
/* get information */
case SNDRV_SB_CSP_IOCTL_INFO:
+ memset(&info, 0, sizeof(info));
*info.codec_name = *p->codec_name;
info.func_nr = p->func_nr;
info.acc_format = p->acc_format;