Disable stack-sizes section by default for PS4.
authorYing Yi <ying.yi@sony.com>
Mon, 18 Jul 2022 18:28:43 +0000 (19:28 +0100)
committerYing Yi <maggieyi666@gmail.com>
Wed, 27 Jul 2022 08:37:20 +0000 (09:37 +0100)
Differential Revision: https://reviews.llvm.org/D130493

clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/stack-size-section.c

index b62a025..d3ff71e 100644 (file)
@@ -5886,9 +5886,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
     CmdArgs.push_back(A->getValue());
   }
 
-  if (Args.hasFlag(options::OPT_fstack_size_section,
-                   options::OPT_fno_stack_size_section, RawTriple.isPS4()))
-    CmdArgs.push_back("-fstack-size-section");
+  Args.addOptInFlag(CmdArgs, options::OPT_fstack_size_section,
+                    options::OPT_fno_stack_size_section);
 
   if (Args.hasArg(options::OPT_fstack_usage)) {
     CmdArgs.push_back("-stack-usage-file");
index f50c976..b99b140 100644 (file)
@@ -4,7 +4,7 @@
 // CHECK-ABSENT-NOT: -fstack-size-section
 
 // RUN: %clang -target x86_64-unknown -fstack-size-section -### 2>&1 | FileCheck %s --check-prefix=CHECK-PRESENT
-// RUN: %clang -target x86_64-scei-ps4 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-PRESENT
+// RUN: %clang -target x86_64-scei-ps4 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT
 // CHECK-PRESENT: -fstack-size-section
 
 // RUN: %clang -target x86_64-unknown -fstack-size-section -fno-stack-size-section %s -### 2>&1 \