touchpad: correct a comment regarding the touchpad integration
authorPeter Hutterer <peter.hutterer@who-t.net>
Tue, 12 May 2020 03:46:04 +0000 (13:46 +1000)
committerPeter Hutterer <peter.hutterer@who-t.net>
Tue, 12 May 2020 03:46:57 +0000 (13:46 +1000)
The previous text wasn't accurate enough, USB used to be considered
external but we've since started deferring to the hwdb for those (except
Apple).

Fixes #483

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
src/evdev-mt-touchpad.c

index 38745cdfb6590963c30439d674be5a4b10704b73..42e8dec64a65d9414fa5e714d4babd7425112719 100644 (file)
@@ -2681,10 +2681,15 @@ evdev_tag_touchpad(struct evdev_device *device,
                }
        }
 
-       /* simple approach: touchpads on USB or Bluetooth are considered
-        * external, anything else is internal. Exception is Apple -
-        * internal touchpads are connected over USB and it doesn't have
-        * external USB touchpads anyway.
+       /* The hwdb is the authority on integration, these heuristics are
+        * the fallback only (they precede the hwdb too).
+        *
+        * Simple approach: USB is unknown, with the exception
+        * of Apple where internal touchpads are connected over USB and it
+        * doesn't have external USB touchpads anyway.
+        *
+        * Bluetooth touchpads are considered external, anything else is
+        * internal.
         */
        bustype = libevdev_get_id_bustype(device->evdev);
        vendor = libevdev_get_id_vendor(device->evdev);