PM: sleep: Do not assume that "mem" is always present
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 15 Sep 2021 02:23:28 +0000 (19:23 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 15 Sep 2021 12:04:04 +0000 (14:04 +0200)
An implementation of suspend_ops is allowed to reject the PM_SUSPEND_MEM
suspend type from its ->valid() callback, we should not assume that it
is always present as this is not a correct reflection of what a firmware
interface may support.

Fixes: 406e79385f32 ("PM / sleep: System sleep state selection interface rework")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/suspend.c

index eb75f39..02e306a 100644 (file)
@@ -171,8 +171,7 @@ static bool valid_state(suspend_state_t state)
 
 void __init pm_states_init(void)
 {
-       /* "mem" and "freeze" are always present in /sys/power/state. */
-       pm_states[PM_SUSPEND_MEM] = pm_labels[PM_SUSPEND_MEM];
+       /* "freeze" is always present in /sys/power/state. */
        pm_states[PM_SUSPEND_TO_IDLE] = pm_labels[PM_SUSPEND_TO_IDLE];
        /*
         * Suspend-to-idle should be supported even without any suspend_ops,
@@ -214,6 +213,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops)
        }
        if (valid_state(PM_SUSPEND_MEM)) {
                mem_sleep_states[PM_SUSPEND_MEM] = mem_sleep_labels[PM_SUSPEND_MEM];
+               pm_states[PM_SUSPEND_MEM] = pm_labels[PM_SUSPEND_MEM];
                if (mem_sleep_default >= PM_SUSPEND_MEM)
                        mem_sleep_current = PM_SUSPEND_MEM;
        }