projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d9f0cf9
)
spi: spi-qcom-qspi: replace spin_lock_irqsave by spin_lock in hard IRQ
author
Barry Song
<song.bao.hua@hisilicon.com>
Thu, 10 Sep 2020 10:02:46 +0000
(22:02 +1200)
committer
Mark Brown
<broonie@kernel.org>
Mon, 14 Sep 2020 14:50:10 +0000
(15:50 +0100)
It is redundant to do irqsave and irqrestore in hardIRQ context.
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link:
https://lore.kernel.org/r/20200910100246.32696-1-song.bao.hua@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qcom-qspi.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-qcom-qspi.c
b/drivers/spi/spi-qcom-qspi.c
index
c50e607
..
5eed88a
100644
(file)
--- a/
drivers/spi/spi-qcom-qspi.c
+++ b/
drivers/spi/spi-qcom-qspi.c
@@
-420,9
+420,8
@@
static irqreturn_t qcom_qspi_irq(int irq, void *dev_id)
u32 int_status;
struct qcom_qspi *ctrl = dev_id;
irqreturn_t ret = IRQ_NONE;
- unsigned long flags;
- spin_lock
_irqsave(&ctrl->lock, flags
);
+ spin_lock
(&ctrl->lock
);
int_status = readl(ctrl->base + MSTR_INT_STATUS);
writel(int_status, ctrl->base + MSTR_INT_STATUS);
@@
-450,7
+449,7
@@
static irqreturn_t qcom_qspi_irq(int irq, void *dev_id)
spi_finalize_current_transfer(dev_get_drvdata(ctrl->dev));
}
- spin_unlock
_irqrestore(&ctrl->lock, flags
);
+ spin_unlock
(&ctrl->lock
);
return ret;
}