Use constant length for memcpy on A64 simulator.

Compiler can't optimize away variable length memcpy.
About a 18% boost.

Before - 5:40

Richards: 75.2
DeltaBlue: 105
Crypto: 64.0
RayTrace: 188
EarleyBoyer: 146
RegExp: 23.8
Splay: 96.2
NavierStokes: 91.9
----
Score (version 7): 85.7

After - 4:39

Richards: 90.8
DeltaBlue: 134
Crypto: 81.7
RayTrace: 227
EarleyBoyer: 177
RegExp: 29.7
Splay: 126
NavierStokes: 108
----
Score (version 7): 106

R=rodolph.perfetta@gmail.com, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/203263017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20141 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/a64/simulator-a64.h b/src/a64/simulator-a64.h
index 1ef891a151ecee375870f5e6073f01cc93d1d773..db585341c1f1b8f1cedfcfc13adec8c6f78f85bb 100644 (file)
--- a/src/a64/simulator-a64.h
+++ b/src/a64/simulator-a64.h
@@ -166,10 +166,18 @@ class SimRegisterBase {
   void Set(T new_value, unsigned size = sizeof(T)) {
     ASSERT(size <= kSizeInBytes);
     ASSERT(size <= sizeof(new_value));
+    STATIC_ASSERT(kXRegSize == kDRegSize);
+    STATIC_ASSERT(kWRegSize == kSRegSize);
     // All AArch64 registers are zero-extending; Writing a W register clears the
     // top bits of the corresponding X register.
-    memset(value_, 0, kSizeInBytes);
-    memcpy(value_, &new_value, size);
+    if (size == kXRegSize) {
+      memcpy(value_, &new_value, kXRegSize);
+    } else if (size == kWRegSize) {
+      memset(value_, 0, kSizeInBytes);
+      memcpy(value_, &new_value, kWRegSize);
+    } else {
+      UNREACHABLE();
+    }
   }
 
   // Copy 'size' bytes of the register to the result, and zero-extend to fill
@@ -178,8 +186,14 @@ class SimRegisterBase {
   T Get(unsigned size = sizeof(T)) const {
     ASSERT(size <= kSizeInBytes);
     T result;
-    memset(&result, 0, sizeof(result));
-    memcpy(&result, value_, size);
+    if (size == kXRegSize) {
+      memcpy(&result, value_, kXRegSize);
+    } else if (size == kWRegSize) {
+      memset(&result, 0, sizeof(result));
+      memcpy(&result, value_, kWRegSize);
+    } else {
+      UNREACHABLE();
+    }
     return result;
   }