net: ethernet: microchip: lan743x: Fix driver crash when lan743x_pm_resume fails
authorYuiko Oshino <yuiko.oshino@microchip.com>
Fri, 22 Oct 2021 15:13:53 +0000 (11:13 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Nov 2021 18:48:23 +0000 (19:48 +0100)
commit d6423d2ec39cce2bfca418c81ef51792891576bc upstream.

The driver needs to clean up and return when the initialization fails on resume.

Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/microchip/lan743x_main.c

index 8947c3a..79fd031 100644 (file)
@@ -3066,6 +3066,8 @@ static int lan743x_pm_resume(struct device *dev)
        if (ret) {
                netif_err(adapter, probe, adapter->netdev,
                          "lan743x_hardware_init returned %d\n", ret);
+               lan743x_pci_cleanup(adapter);
+               return ret;
        }
 
        /* open netdev when netdev is at running state while resume.