selftests/bpf: fix clearing buffered output between tests/subtests
authorAndrii Nakryiko <andriin@fb.com>
Tue, 30 Jul 2019 18:05:41 +0000 (11:05 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 31 Jul 2019 04:12:38 +0000 (21:12 -0700)
Clear buffered output once test or subtests finishes even if test was
successful. Not doing this leads to accumulation of output from previous
tests and on first failed tests lots of irrelevant output will be
dumped, greatly confusing things.

v1->v2: fix Fixes tag, add more context to patch

Fixes: 3a516a0a3a7b ("selftests/bpf: add sub-tests support for test_progs")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/test_progs.c

index 546d99b..db00196 100644 (file)
@@ -46,8 +46,8 @@ static void dump_test_log(const struct prog_test_def *test, bool failed)
                        if (env.log_buf[env.log_cnt - 1] != '\n')
                                fprintf(stdout, "\n");
                }
-               env.log_cnt = 0;
        }
+       env.log_cnt = 0;
 }
 
 void test__end_subtest()