drm/sis: use idr_init_base() to initialize dev_priv->object_idr
authorDanilo Krummrich <dakr@redhat.com>
Fri, 1 Jul 2022 18:53:00 +0000 (20:53 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 28 Jul 2022 14:35:56 +0000 (15:35 +0100)
idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based
IDRs more efficient"), let us set an arbitrary base other than
idr_init(), which uses base 0.

Since, for this IDR, no ID < 1 is ever requested/allocated, using
idr_init_base(&idr, 1) avoids unnecessary tree walks.

Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220701185303.284082-8-dakr@redhat.com
drivers/gpu/drm/sis/sis_drv.c

index e35e719cf315b30ce5646fa929bc69bceec51e92..6173020a9bf56a44b37451c7b78031669ad9e31e 100644 (file)
@@ -50,7 +50,7 @@ static int sis_driver_load(struct drm_device *dev, unsigned long chipset)
        if (dev_priv == NULL)
                return -ENOMEM;
 
-       idr_init(&dev_priv->object_idr);
+       idr_init_base(&dev_priv->object_idr, 1);
        dev->dev_private = (void *)dev_priv;
        dev_priv->chipset = chipset;