projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c94be1f
)
regulator: Fix error checking for debugfs_create_dir
author
Osama Muhammad
<osmtendev@gmail.com>
Mon, 15 May 2023 17:29:38 +0000
(22:29 +0500)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 21 Jun 2023 14:00:52 +0000
(16:00 +0200)
[ Upstream commit
2bf1c45be3b8f3a3f898d0756c1282f09719debd
]
This patch fixes the error checking in core.c in debugfs_create_dir.
The correct way to check if an error occurred is 'IS_ERR' inline function.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com
Suggested-by: Ivan Orlov <ivan.orlov0322@gmail.com
Link:
https://lore.kernel.org/r/20230515172938.13338-1-osmtendev@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/core.c
patch
|
blob
|
history
diff --git
a/drivers/regulator/core.c
b/drivers/regulator/core.c
index
c417eae
..
e01cade
100644
(file)
--- a/
drivers/regulator/core.c
+++ b/
drivers/regulator/core.c
@@
-5257,7
+5257,7
@@
static void rdev_init_debugfs(struct regulator_dev *rdev)
}
rdev->debugfs = debugfs_create_dir(rname, debugfs_root);
- if (
!rdev->debugfs
) {
+ if (
IS_ERR(rdev->debugfs)
) {
rdev_warn(rdev, "Failed to create debugfs directory\n");
return;
}
@@
-6179,7
+6179,7
@@
static int __init regulator_init(void)
ret = class_register(®ulator_class);
debugfs_root = debugfs_create_dir("regulator", NULL);
- if (
!debugfs_root
)
+ if (
IS_ERR(debugfs_root)
)
pr_warn("regulator: Failed to create debugfs directory\n");
#ifdef CONFIG_DEBUG_FS