mtd: rawnand: fsmc: Use nand_op_trace for operation tracing
authorSascha Hauer <s.hauer@pengutronix.de>
Tue, 21 May 2019 07:06:31 +0000 (09:06 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 27 Jun 2019 18:05:26 +0000 (20:05 +0200)
Replace the different operation tracing functions with a call to
nand_op_trace.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/fsmc_nand.c

index 6c7ca41..a6964fe 100644 (file)
@@ -613,28 +613,20 @@ static int fsmc_exec_op(struct nand_chip *chip, const struct nand_operation *op,
        for (op_id = 0; op_id < op->ninstrs; op_id++) {
                instr = &op->instrs[op_id];
 
+               nand_op_trace("  ", instr);
+
                switch (instr->type) {
                case NAND_OP_CMD_INSTR:
-                       pr_debug("  ->CMD      [0x%02x]\n",
-                                instr->ctx.cmd.opcode);
-
                        writeb_relaxed(instr->ctx.cmd.opcode, host->cmd_va);
                        break;
 
                case NAND_OP_ADDR_INSTR:
-                       pr_debug("  ->ADDR     [%d cyc]",
-                                instr->ctx.addr.naddrs);
-
                        for (i = 0; i < instr->ctx.addr.naddrs; i++)
                                writeb_relaxed(instr->ctx.addr.addrs[i],
                                               host->addr_va);
                        break;
 
                case NAND_OP_DATA_IN_INSTR:
-                       pr_debug("  ->DATA_IN  [%d B%s]\n", instr->ctx.data.len,
-                                instr->ctx.data.force_8bit ?
-                                ", force 8-bit" : "");
-
                        if (host->mode == USE_DMA_ACCESS)
                                fsmc_read_buf_dma(host, instr->ctx.data.buf.in,
                                                  instr->ctx.data.len);
@@ -644,10 +636,6 @@ static int fsmc_exec_op(struct nand_chip *chip, const struct nand_operation *op,
                        break;
 
                case NAND_OP_DATA_OUT_INSTR:
-                       pr_debug("  ->DATA_OUT [%d B%s]\n", instr->ctx.data.len,
-                                instr->ctx.data.force_8bit ?
-                                ", force 8-bit" : "");
-
                        if (host->mode == USE_DMA_ACCESS)
                                fsmc_write_buf_dma(host,
                                                   instr->ctx.data.buf.out,
@@ -658,9 +646,6 @@ static int fsmc_exec_op(struct nand_chip *chip, const struct nand_operation *op,
                        break;
 
                case NAND_OP_WAITRDY_INSTR:
-                       pr_debug("  ->WAITRDY  [max %d ms]\n",
-                                instr->ctx.waitrdy.timeout_ms);
-
                        ret = nand_soft_waitrdy(chip,
                                                instr->ctx.waitrdy.timeout_ms);
                        break;