sfc: Don't use netif_info before net_device setup
authorErik Ekman <erik@kryo.se>
Tue, 19 Oct 2021 22:40:16 +0000 (00:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Oct 2021 11:39:13 +0000 (12:39 +0100)
Use pci_info instead to avoid unnamed/uninitialized noise:

[197088.688729] sfc 0000:01:00.0: Solarflare NIC detected
[197088.690333] sfc 0000:01:00.0: Part Number : SFN5122F
[197088.729061] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no SR-IOV VFs probed
[197088.729071] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no PTP support

Inspired by fa44821a4ddd ("sfc: don't use netif_info et al before
net_device is registered") from Heiner Kallweit.

Signed-off-by: Erik Ekman <erik@kryo.se>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ptp.c
drivers/net/ethernet/sfc/siena_sriov.c

index a39c514..797e518 100644 (file)
@@ -648,7 +648,7 @@ static int efx_ptp_get_attributes(struct efx_nic *efx)
        } else if (rc == -EINVAL) {
                fmt = MC_CMD_PTP_OUT_GET_ATTRIBUTES_SECONDS_NANOSECONDS;
        } else if (rc == -EPERM) {
-               netif_info(efx, probe, efx->net_dev, "no PTP support\n");
+               pci_info(efx->pci_dev, "no PTP support\n");
                return rc;
        } else {
                efx_mcdi_display_error(efx, MC_CMD_PTP, sizeof(inbuf),
@@ -824,7 +824,7 @@ static int efx_ptp_disable(struct efx_nic *efx)
         * should only have been called during probe.
         */
        if (rc == -ENOSYS || rc == -EPERM)
-               netif_info(efx, probe, efx->net_dev, "no PTP support\n");
+               pci_info(efx->pci_dev, "no PTP support\n");
        else if (rc)
                efx_mcdi_display_error(efx, MC_CMD_PTP,
                                       MC_CMD_PTP_IN_DISABLE_LEN,
index 83dcfca..441e7f3 100644 (file)
@@ -1057,7 +1057,7 @@ void efx_siena_sriov_probe(struct efx_nic *efx)
                return;
 
        if (efx_siena_sriov_cmd(efx, false, &efx->vi_scale, &count)) {
-               netif_info(efx, probe, efx->net_dev, "no SR-IOV VFs probed\n");
+               pci_info(efx->pci_dev, "no SR-IOV VFs probed\n");
                return;
        }
        if (count > 0 && count > max_vfs)