net: mdio-uclass: rewrite dm_mdio_post_probe using strlcpy
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 27 Sep 2021 11:22:00 +0000 (14:22 +0300)
committerRamon Fried <rfried.dev@gmail.com>
Tue, 28 Sep 2021 15:50:57 +0000 (18:50 +0300)
dm_mdio_post_probe used to be vulnerable after truncation, but has been
patched by commit 398e7512d8d7 ("net: Fix Covarity Defect 244093").
Nonetheless, we can use strlcpy like the rest of the code base now,
which yields the same result.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
net/mdio-uclass.c

index 1b68776..e74e34f 100644 (file)
@@ -101,7 +101,7 @@ static int dm_mdio_post_probe(struct udevice *dev)
        pdata->mii_bus->write = mdio_write;
        pdata->mii_bus->reset = mdio_reset;
        pdata->mii_bus->priv = dev;
-       strncpy(pdata->mii_bus->name, dev->name, MDIO_NAME_LEN - 1);
+       strlcpy(pdata->mii_bus->name, dev->name, MDIO_NAME_LEN);
 
        return mdio_register(pdata->mii_bus);
 }