utils: Use cpu_to_fdt32() when writing to fdt
authorGeorg Kotheimer <georg.kotheimer@kernkonzept.com>
Wed, 24 Jul 2019 09:38:14 +0000 (11:38 +0200)
committerAnup Patel <anup.patel@wdc.com>
Thu, 25 Jul 2019 03:29:50 +0000 (08:59 +0530)
Although it does not make a functional difference, both cpu_to_fdt32()
and fdt32_to_cpu() pass on to CPU_TO_FDT32, we should use cpu_to_fdt32()
to be semantically correct.

Signed-off-by: Georg Kotheimer <georg.kotheimer@kernkonzept.com>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
Acked-by: Anup Patel <anup.patel@wdc.com>
lib/utils/irqchip/plic.c

index 2cd055e..5dcbce0 100644 (file)
@@ -68,7 +68,7 @@ void plic_fdt_fixup(void *fdt, const char *compat)
 
        for (i = 0; i < (cells_count / 2); i++) {
                if (fdt32_to_cpu(cells[2 * i + 1]) == IRQ_M_EXT)
-                       cells[2 * i + 1] = fdt32_to_cpu(0xffffffff);
+                       cells[2 * i + 1] = cpu_to_fdt32(0xffffffff);
        }
 }