scsi: sd: Warn if unsupported ZBC device is probed
authorDamien Le Moal <damien.lemoal@wdc.com>
Thu, 28 Jan 2021 05:56:58 +0000 (14:56 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 9 Feb 2021 02:11:32 +0000 (21:11 -0500)
In sd_probe(), print a warning if CONFIG_BLK_DEV_ZONED is disabled and a
TYPE_ZBC device is found. While at it, use IS_ENABLED() to test if
CONFIG_BLK_DEV_ZONED is enabled instead using of a #ifdef.

Link: https://lore.kernel.org/r/20210128055658.530133-1-damien.lemoal@wdc.com
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c

index a3d2d4b..6e41ecb 100644 (file)
@@ -3379,10 +3379,12 @@ static int sd_probe(struct device *dev)
            sdp->type != TYPE_RBC)
                goto out;
 
-#ifndef CONFIG_BLK_DEV_ZONED
-       if (sdp->type == TYPE_ZBC)
+       if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED) && sdp->type == TYPE_ZBC) {
+               sdev_printk(KERN_WARNING, sdp,
+                           "Unsupported ZBC host-managed device.\n");
                goto out;
-#endif
+       }
+
        SCSI_LOG_HLQUEUE(3, sdev_printk(KERN_INFO, sdp,
                                        "sd_probe\n"));