tracker: Refactor query triplets
authorLukasz Pawlik <lucas.pawlik@gmail.com>
Tue, 8 Nov 2011 14:42:17 +0000 (15:42 +0100)
committerJens Georg <mail@jensge.org>
Sun, 11 Dec 2011 16:57:33 +0000 (17:57 +0100)
Use add method from base class.

src/plugins/tracker/rygel-tracker-new.vala
src/plugins/tracker/rygel-tracker-query-triplets.vala
src/plugins/tracker/rygel-tracker-search-container.vala

index 9b87fc8..b725385 100644 (file)
@@ -34,12 +34,12 @@ public class Rygel.Tracker.New : Rygel.Tracker.SearchContainer {
     public New (MediaContainer parent, ItemFactory item_factory) {
         var triplets = new QueryTriplets ();
 
-        triplets.add_triplet (new QueryTriplet (SelectionQuery.ITEM_VARIABLE,
-                                                "a",
-                                                item_factory.category));
-        triplets.add_triplet (new QueryTriplet (SelectionQuery.ITEM_VARIABLE,
-                                                ADDED_PREDICATE,
-                                                ADDED_VARIABLE));
+        triplets.add (new QueryTriplet (SelectionQuery.ITEM_VARIABLE,
+                                        "a",
+                                        item_factory.category));
+        triplets.add (new QueryTriplet (SelectionQuery.ITEM_VARIABLE,
+                                        ADDED_PREDICATE,
+                                        ADDED_VARIABLE));
 
         var time = TimeVal ();
         time.tv_sec -= THREE_DAYS_AS_SEC;
index e8192ac..89b678b 100644 (file)
@@ -73,12 +73,12 @@ public class Rygel.Tracker.QueryTriplets : ArrayList<QueryTriplet> {
         return str;
     }
 
-    // FIXME: Remove this method and override 'add' method from the base class
-    //        instead once bug#623685 is fixed.
-    public void add_triplet (QueryTriplet triplet) {
+    public override bool add (QueryTriplet triplet) {
         if (!this.contains (triplet)) {
-            this.add (triplet);
+            return base.add (triplet);
         }
+
+        return false;
     }
 
     private bool check_graph_change (int i) {
index b913c8a..5145cdd 100644 (file)
@@ -77,10 +77,10 @@ public class Rygel.Tracker.SearchContainer : SimpleContainer {
             our_triplets = new QueryTriplets ();
         }
 
-        our_triplets.add_triplet (new QueryTriplet
-                                        (SelectionQuery.ITEM_VARIABLE,
-                                         "a",
-                                         item_factory.category));
+        our_triplets.add (new QueryTriplet
+                                (SelectionQuery.ITEM_VARIABLE,
+                                 "a",
+                                 item_factory.category));
 
         var key_chain_map = KeyChainMap.get_key_chain_map ();
         foreach (var property in this.item_factory.properties) {