ipmi_ssif: remove redundant null check on array client->adapter->name
authorColin Ian King <colin.king@canonical.com>
Sun, 7 May 2017 18:05:16 +0000 (19:05 +0100)
committerCorey Minyard <cminyard@mvista.com>
Wed, 17 May 2017 23:30:35 +0000 (18:30 -0500)
The null check on client->adapter->name is redundant as name is an
array of I2C_NAME_SIZE chars and hence can never be null. We may as
well remove this redundant check.

Detected by CoverityScan, CID#1375918 ("Array compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_ssif.c

index 6dd6476..1d4fd84 100644 (file)
@@ -1419,8 +1419,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
        list_for_each_entry(info, &ssif_infos, link) {
                if (info->binfo.addr != client->addr)
                        continue;
-               if (info->adapter_name && client->adapter->name &&
-                   strcmp_nospace(info->adapter_name,
+               if (info->adapter_name && strcmp_nospace(info->adapter_name,
                                   client->adapter->name))
                        continue;
                if (info->slave_addr) {