pulsesink: Free format_info in query_getcaps
authorJimmy Ohn <yongjin.ohn@lge.com>
Tue, 20 Jan 2015 00:32:00 +0000 (00:32 +0000)
committerThiago Santos <thiagoss@osg.samsung.com>
Mon, 26 Jan 2015 15:07:20 +0000 (12:07 -0300)
If we can not create probe stream in query_getcaps function, it will appear
memory leakage from format info.
The following patch prevent memory leakage in pulsesink.

https://bugzilla.gnome.org/show_bug.cgi?id=743178

ext/pulse/pulsesink.c

index c20b0a0..abad2b8 100644 (file)
@@ -2164,13 +2164,14 @@ gst_pulsesink_query_getcaps (GstPulseSink * psink, GstCaps * filter)
 
     pbuf->probe_stream = gst_pulsesink_create_probe_stream (psink, pbuf,
         format);
+
+    pa_format_info_free (format);
+
     if (!pbuf->probe_stream) {
       GST_WARNING_OBJECT (psink, "Could not create probe stream");
       goto unlock;
     }
 
-    pa_format_info_free (format);
-
     stream = pbuf->probe_stream;
   }