Fix svace issues 98/90298/1 accepted/tizen/common/20160929.163821 accepted/tizen/ivi/20160929.234238 accepted/tizen/mobile/20160929.234225 accepted/tizen/tv/20160929.234208 accepted/tizen/wearable/20160929.234202 submit/tizen/20160929.101126
authorstom.hwang <stom.hwang@samsung.com>
Thu, 29 Sep 2016 09:51:44 +0000 (18:51 +0900)
committerstom.hwang <stom.hwang@samsung.com>
Thu, 29 Sep 2016 09:51:44 +0000 (18:51 +0900)
Change-Id: I46458eec46811d738673a69b193ad3f4dcf30841
Signed-off-by: stom.hwang <stom.hwang@samsung.com>
src/vc_elm_core.c [changed mode: 0644->0755]

old mode 100644 (file)
new mode 100755 (executable)
index 91f96dc..c35866e
@@ -904,7 +904,6 @@ void _show_tooltips()
        Eina_List *_l;
        Evas_Object *obj = NULL;
        Evas_Object *parent = NULL;
-       struct vc_elm_core_widget_info *info = NULL;
        const char *obj_name = NULL;
        const char *parent_obj_name = NULL;
        Evas_Coord x;
@@ -921,7 +920,6 @@ void _show_tooltips()
        VC_ELM_LOG_DBG("show_tooltips");
        EINA_LIST_FOREACH(g_current_ui_objects, _l, obj) {
                parent = elm_object_parent_widget_get(obj);
-               info = NULL;
                obj_name = _get_ui_object_name(obj);
                parent_obj_name = _get_ui_object_name(parent);
 
@@ -954,7 +952,7 @@ void _show_tooltips()
                                if ((y < y_p - Y_VISIBILITY_TOLERANCE) || (y + h > y_p + h_p + Y_VISIBILITY_TOLERANCE) || (x < x_p - X_VISIBILITY_TOLERANCE) || (x + w > y_p + w_p + X_VISIBILITY_TOLERANCE))
                                        continue;
                        }
-               } else if (NULL == (info = eina_hash_find(g_widget_info_hash, obj_name))) {
+               } else if (NULL == eina_hash_find(g_widget_info_hash, obj_name)) {
                        VC_ELM_LOG_DBG("[TOOLTIP] Widget type '%s' not supported", obj_name);
                        continue;
                } else if (!strcmp(obj_name, "Elm_Naviframe")) {
@@ -1851,7 +1849,7 @@ int _vc_elm_core_read_xml_data()
        }
 
        root = main_node->xmlChildrenNode;
-       do {
+       while (root != NULL) {
                VC_ELM_LOG_DBG("Root nodes mames %s", root->name);
                if (0 == xmlStrcmp(root->name, XML_CAST VC_ELM_TAG_BASE_NAME)) {
                        cur = root->xmlChildrenNode;
@@ -1865,11 +1863,11 @@ int _vc_elm_core_read_xml_data()
                                if (0 == xmlStrcmp(cur->name, XML_CAST VC_ELM_TAG_ACTION_LIST)) {
                                        child = cur->xmlChildrenNode;
                                        VC_ELM_LOG_DBG("xml pointer last %s %p", cur->last->name, (void *)cur->last);
-                                       do {
+                                       while (child != NULL) {
                                                if (0 == xmlStrcmp(child->name, XML_CAST VC_ELM_TAG_ACTION_GROUP)) {
                                                        const char *action_name = NULL;
                                                        tmp = child->xmlChildrenNode;
-                                                       do {
+                                                       while (tmp != NULL) {
                                                                if (0 == xmlStrcmp(tmp->name, XML_CAST VC_ELM_TAG_ACTION_NAME)) {
                                                                        key = xmlNodeGetContent(tmp);
                                                                        VC_ELM_LOG_DBG("action name %s", (char *)key);
@@ -1886,17 +1884,17 @@ int _vc_elm_core_read_xml_data()
                                                                        xmlFree(key);
                                                                }
                                                                tmp = tmp->next;
-                                                       } while (tmp != NULL);
+                                                       }
                                                }
                                                child = child->next;
-                                       } while (child != NULL);
+                                       }
                                } else if (0 == xmlStrcmp(cur->name, XML_CAST VC_ELM_TAG_WIDGET_LIST)) {
                                        child = cur->xmlChildrenNode;
-                                       do {
+                                       while (child != NULL) {
                                                if (0 == xmlStrcmp(child->name, XML_CAST VC_ELM_TAG_WIDGET_GROUP)) {
                                                        const char *widget_name = NULL;
                                                        tmp = child->xmlChildrenNode;
-                                                       do {
+                                                       while (tmp != NULL) {
                                                                if (0 == xmlStrcmp(tmp->name, XML_CAST VC_ELM_TAG_WIDGET_NAME)) {
                                                                        key = xmlNodeGetContent(tmp);
                                                                        VC_ELM_LOG_DBG("widget name %s", (char *)key);
@@ -1905,7 +1903,7 @@ int _vc_elm_core_read_xml_data()
                                                                } else if (0 == xmlStrcmp(tmp->name, XML_CAST VC_ELM_TAG_WIDGET_ACTIONS)) {
                                                                        xmlNodePtr actions = tmp->xmlChildrenNode;
                                                                        Eina_List *actions_list = NULL;
-                                                                       do {
+                                                                       while (actions != NULL) {
                                                                                if (0 == xmlStrcmp(actions->name, XML_CAST VC_ELM_TAG_ACTION_NAME)) {
                                                                                        const char *action_tag = NULL;
                                                                                        key = xmlNodeGetContent(actions);
@@ -1915,18 +1913,18 @@ int _vc_elm_core_read_xml_data()
                                                                                        xmlFree(key);
                                                                                }
                                                                                actions = actions->next;
-                                                                       } while (actions != NULL);
+                                                                       }
                                                                        if (widget_name != NULL && actions_list != NULL)
                                                                                eina_hash_add(g_config_widget_map, widget_name, actions_list);
                                                                }
                                                                tmp = tmp->next;
-                                                       } while (tmp != NULL);
+                                                       }
                                                }
                                                child = child->next;
-                                       } while (child != NULL);
+                                       }
                                } else if (0 == xmlStrcmp(cur->name, XML_CAST VC_ELM_TAG_HINT_GROUP)) {
                                        child = cur->xmlChildrenNode;
-                                       do {
+                                       while (child != NULL) {
                                                if (0 == xmlStrcmp(child->name, XML_CAST VC_ELM_TAG_HINT_SHOW)) {
                                                        key = xmlNodeGetContent(child);
                                                        VC_ELM_LOG_DBG("hint show %s", (char*)key);
@@ -1951,13 +1949,13 @@ int _vc_elm_core_read_xml_data()
                                                        xmlFree(key);
                                                }
                                                child = child->next;
-                                       } while (child != NULL);
+                                       }
                                }
                                cur = cur->next;
                        } while (cur != NULL);
                } else if (0 == xmlStrcmp(root->name, XML_CAST VC_ELM_TAG_BASE_INFO)) {
                        cur = root->xmlChildrenNode;
-                       do {
+                       while (cur != NULL) {
                                if (0 == xmlStrcmp(cur->name, XML_CAST VC_ELM_TAG_TIZEN_VERSION)) {
                                        key = xmlNodeGetContent(cur);
                                        VC_ELM_LOG_DBG("hint direction %s", (char*)key);
@@ -1972,10 +1970,10 @@ int _vc_elm_core_read_xml_data()
                                        xmlFree(key);
                                }
                                cur = cur->next;
-                       } while (cur != NULL);
+                       }
                }
                root = root->next;
-       } while (root != NULL);
+       }
 
        xmlFreeDoc(doc);