sensord: remove sensord compiler warnings 49/61249/1
authorkibak.yoon <kibak.yoon@samsung.com>
Mon, 7 Mar 2016 04:15:52 +0000 (13:15 +0900)
committerkibak.yoon <kibak.yoon@samsung.com>
Mon, 7 Mar 2016 04:15:52 +0000 (13:15 +0900)
Change-Id: I2a8136c8bdd25fad9a6824ddbbff7c90ec26c529
Signed-off-by: kibak.yoon <kibak.yoon@samsung.com>
src/client/client_common.h
src/client/sensor_event_listener.cpp
src/server/sensor_event_dispatcher.cpp
src/server/sensor_loader.cpp
src/test/src/sensor-test.c

index 85606db..8b5ec8e 100644 (file)
 #include <sensor_log.h>
 
 #define BASE_GATHERING_INTERVAL        100
-
 #define CLIENT_NAME_SIZE NAME_MAX+10
 
 struct log_attr {
-       char *sensor_name;
-       char *event_name;
+       const char *sensor_name;
+       const char *event_name;
 };
 
 bool is_one_shot_event(unsigned int event_type);
index 9e14fc2..778392d 100644 (file)
@@ -28,7 +28,7 @@
 #include <sensor_types.h>
 
 /* TODO: this macro should be adjusted(4224 = 4096(data) + 128(header)) */
-#define EVENT_BUFFER_SIZE 4224
+#define EVENT_BUFFER_SIZE sizeof(sensor_event_t)
 
 using std::thread;
 using std::pair;
@@ -368,7 +368,8 @@ void sensor_event_listener::listen_events(void)
                        break;
                }
 
-               data_len = ((sensor_event_t *)buffer)->data_length;
+               sensor_event_t *sensor_event = reinterpret_cast<sensor_event_t *>(buffer);
+               data_len = sensor_event->data_length;
                buffer_data = malloc(data_len);
 
                len = sensor_event_poll(buffer_data, data_len, event);
@@ -378,7 +379,7 @@ void sensor_event_listener::listen_events(void)
                        break;
                }
 
-               ((sensor_event_t *)buffer)->data = (sensor_data_t *)buffer_data;
+               sensor_event->data = reinterpret_cast<sensor_data_t *>(buffer_data);
 
                handle_events((void *)buffer);
        } while (true);
index df64e80..b03a5e4 100644 (file)
@@ -151,10 +151,8 @@ void sensor_event_dispatcher::send_sensor_events(vector<void *> &events)
        for (unsigned int i = 0; i < events.size(); ++i) {
                sensor_id_t sensor_id;
                unsigned int event_type;
-               int length;
 
                sensor_event = (sensor_event_t*)events[i];
-               length = sizeof(sensor_event_t) + sensor_event->data_length;
                sensor_id = sensor_event->sensor_id;
                event_type = sensor_event->event_type;
 
index d8636f1..5626214 100644 (file)
@@ -260,7 +260,7 @@ bool sensor_loader::get_paths_from_dir(const string &dir_path, vector<string> &h
 
        string name;
 
-       while (dir_entry = readdir(dir)) {
+       while ((dir_entry = readdir(dir))) {
                name = string(dir_entry->d_name);
 
                if (name == "." || name == "..")
index 9f5310f..823f246 100644 (file)
@@ -215,7 +215,11 @@ int main(int argc, char **argv)
                arg.event = event;
                arg.interval = interval;
 
-               return check_sensor((void*)&arg);
+               void *result = check_sensor((void*)&arg);
 
+               if (!result)
+                       return -1;
+
+               return 0;
        }
 }