staging: rtl8192u: make read-only array EWC11NHTCap static const
authorColin Ian King <colin.i.king@gmail.com>
Thu, 14 Apr 2022 10:36:50 +0000 (11:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Apr 2022 16:21:55 +0000 (18:21 +0200)
Don't populate the read-only array EWC11NHTCap on the stack but instead
make it static const. Also makes the object code a little smaller.
Remove comment.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220414103650.297396-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

index 358c35d..a93f090 100644 (file)
@@ -480,7 +480,7 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u
        }
        memset(posHTCap, 0, *len);
        if (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC) {
-               u8      EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};       // For 11n EWC definition, 2007.07.17, by Emily
+               static const u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
 
                memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
                pCapELE = (struct ht_capability_ele *)&posHTCap[4];